feat(cli): add ACP session creation and listing - #3744
Open
Sun-GLiang wants to merge 6 commits into
Open
Conversation
Sun-GLiang
force-pushed
the
feat/acp-session-lifecycle
branch
from
August 26, 2026 10:08
67c6644 to
4ed9973
Compare
Sun-GLiang
marked this pull request as ready for review
August 26, 2026 10:20
7 tasks
Generated-by: Codex
Generated-by: Codex
Generated-by: Codex
Generated-by: Codex
Generated-by: Codex
Generated-by: Codex
Sun-GLiang
force-pushed
the
feat/acp-session-lifecycle
branch
from
August 29, 2026 01:14
4ed9973 to
951bd81
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
session/newand cursor-paginatedsession/listthrough the official SDK, including canonicalcwdfiltering, legacy-record omission, stable Runtime Host error mapping, and explicit rejection of unsupported MCP server and additional-directory inputs.initializeand unsupported methods remain Host-independent.session/closeunadvertised and returning-32601; durable Runtime Host Sessions are never deleted or archived by adapter cleanup. Active-turn cancellation and adapter-state removal remain follow-up work in PR4 and will be revalidated before that PR starts.Refs #3132
Builds on #3658 (merged)
PR1 alignment
mainafter feat(cli): add ACP stdio server foundation #3658 merged; the PR now contains only the PR2 delta.initializecontract.Verification
npm --workspace maka-agent test— repository total 519 passed, 1 unrelated macOS/private/varversus/varinstallation-path assertion failed.npm --workspace @maka/runtime-host test— 1243 passed, 0 failed, 9 skipped.npm run typechecknpm run lintnpm run format:checkgit diff --checkgit range-diffconfirms the six PR2 commits were preserved across the rebase; the only manual conflict resolution retained both currentmainconnection-availability notifications and PR2's one-shot subscription open.AI use
Select exactly one:
Tool(s) and scope: Codex assisted with implementation, tests, rebase/conflict resolution, verification, and review. Every PR2 commit includes a
Generated-by: Codextrailer.Checklist
Does this PR entail a change in behavior?